Skip to content

feature: incorporate nginx-agent.conf 3.0 changes to Get started guide #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: agent-release-3.0
Choose a base branch
from
Open

feature: incorporate nginx-agent.conf 3.0 changes to Get started guide #685

wants to merge 4 commits into from
+24 −16

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jun 16, 2025

Proposed changes

I have not checked the steps as this PR describes for the Get started guide.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang requested a review from JTorreG June 16, 2025 16:13
@mjang mjang self-assigned this Jun 16, 2025
@mjang mjang requested review from a team as code owners June 16, 2025 16:13
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) product/nginx-one NGINX One Console product/agent NGINX Agent tooling Back end, repository, Hugo, and all things not related to content product/nms NGINX Management Suite (EOS product) labels Jun 16, 2025
@mjang mjang changed the base branch from main to agent-release-3.0 June 16, 2025 16:13
@mjang
Copy link
Contributor Author

mjang commented Jun 16, 2025

Is this easier than I thought?

@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/685/

mjang
mjang commented Jun 16, 2025
View reviewed changes
JTorreG
JTorreG reviewed Jun 16, 2025
View reviewed changes
content/nginx-one/agent/containers/run-agent-container.md
Comment on lines -62 to +54
- `<your-data-plane-key-here>`: Your Data Plane access token.
Replace the placeholder values:

- `<NGINX-One-Console-URL>`: The URL of your NGINX One Console instance, typically https://INSERT_YOUR_TENANT_NAME.console.ves.volterra.io/ .
- `<your-data-plane-key-here>`: Your Data Plane key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add these lines to the include

mjang
mjang commented Jun 16, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JTorreG JTorreG JTorreG left review comments

Assignees

@mjang mjang

Labels
documentation Improvements or additions to documentation product/agent NGINX Agent product/nginx-one NGINX One Console product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) product/nim NGINX Instance Manager product/nms NGINX Management Suite (EOS product) tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjang @JTorreG