Code And Learn at NodeFest 2016

[yosuke-furukawa]

Hi folks.
NodeFest is the largest Node.js conference at Japan.

I am an organizer of the conference, I would like to open code-and-learn-jp on NodeFest.
Japan has 1 collaborator (me) and 1 core team member (shigeki) and some great nodeschool staffs (martin, ledsun, watilde, tako-black, etc). We would like to support contribution to nodejs/core.

And I would like to list up the contribution point of Japanese node beginners.
I guess we will receive some PRs on 12th November.
We will follow English communication and some other commit techniques.

[yosuke-furukawa]

Contributing Point:

doc typo:

• doc/modules.md: line 132 lookups, it would be better looks up.
• doc/cluster.md: line 147, 499 has eg., it would be better e.g..
• doc/repl: line 6 has includable, it would be better includible. http://wikidiff.com/includable/includible
• doc/dns.md: line 263 e.g., => e.g.
• doc/http.md: line 553/856 e.g., => e.g.
• doc/tls.md: line 762 836 1026 e.g., => e.g.

doc improvement:

• doc/url.md does not have WHATWG-URL standard link and the description.

[Trott]

If you need more issues, one thing you can do is search through the test files for assert.equal(). In almost all cases, the test could be improved by using assert.strictEqual() instead. The one exception I can think of might be test-assert.js where use of assert.equa() may be necessary.

[yosuke-furukawa]

Contributing Point:

test:

• test/parallel/test-http-status-reason-invalid-chars.js: use port 0 instead of common.PORT,

const server = http.createServer((req, res) => {
  if (req.url === '/explicit') {
    explicit(req, res);
  } else {
    implicit(req, res);
  }
}).listen(common.PORT, common.mustCall(() => { // should use 0
  const url = `http://localhost:${common.PORT}`; // should use server.address().port
  let left = 2;
  const check = common.mustCall((res) => {
    left--;
    assert.notEqual(res.headers['content-type'], 'text/html');
    assert.notEqual(res.headers['content-type'], 'gotcha');
    if (left === 0) server.close();
  }, 2);
  http.get(`${url}/explicit`, check).end();
  http.get(`${url}/implicit`, check).end();
}));

[yosuke-furukawa]

@Trott thank you!!! sound so good. I am currently searching contribution point on code-and-learn on nodefest.

[Trott]

Here's another one: There are a number of instances of setTimeout() where the function is called without a duration (the second argument). Node.js will treat that the same as calling it with a duration of 1. In many of these cases, it might be better to use setImmediate().

Here are some of those cases. I have not reviewed them to verify that setImmediate() is better, but that might be an appropriate exercise for a first time committer.

• test/sequential/test-next-tick-error-spin.js line 43
• test/parallel/test-tls-hello-parser-failure.js line 30
• test/parallel/test-stream2-writable.js line 331

[yosuke-furukawa]

test: use port 0 instead of common.PORT

• test/parallel/test-cluster-net-send.js

  server.listen(common.PORT, function() { // use 0 port
    socket = net.connect(common.PORT, '127.0.0.1', socketConnected); // use server.address().port
  });

• test/parallel/test-tls-connect-address-family.js
• test/parallel/test-net-socket-destroy-twice.js

[Trott]

Japan has 1 collaborator (me) and 1 core team member (shigeki)

@ronkorving is a collaborator and lives in Tokyo.

[yosuke-furukawa]

@Trott ah, that's so good.
I will list these points.

[ronkorving]

@Trott @yosuke-furukawa Indeed :) I'm not too active in the Japanese Node community, but wouldn't mind trying harder :) My Japanese is not yet 100% what I would like it to be. In any case, I signed up for Sunday (visitor) and wouldn't mind helping with the organization next year either if that's appreciated. I'll see you on Sunday. 楽しみにしてます ^^

[jasnell]

@yosuke-furukawa I'm definitely looking forward to being there and will help out in whatever way that I can. I just want to confirm that the Code and Learn is scheduled for Saturday afternoon, correct? I want to take a little bit of time Saturday morning to sight see a little bit and I want to make sure I plan things so I won't be late to the Code and Learn :-)

[shigeki]

I'm going to join it to help participants and take care of what tests and docs can be good for the first contributions. But actually, the class is just one and half hour so I think it is too short for novices.

Instead of submitting a new PR to nodejs repo, I made an alternative repo of node to give such users the first experiences of contributions in https://github.com/shigeki/node_testpr/ . It can be a training for them if they submit a fake PR such as shigeki/node_testpr#1 .

Users can choice which repo they want to work on during the course.