Node/js/docker images for PPC le

[mhdawson]

I'd like to explore adding support for PPC le along with having the images pushed to docker hub regularly. The binaries are available on the Node.js download site and we have PPC le machines in the Node.js community CI. What I don't see in the readme is where I'd find info on the automation used to build/push the images.

[pesho]

Hi @mhdawson, the official images are built using metadata from this repository: https://github.com/docker-library/official-images - to which we contribute updates via pull requests. Please take a look at the "Architectures other than amd64" section there, it explains the current status regarding other architectures.

[chorrell]

There currently is no automation. We update the docker files in this repo via some scripting (like update.sh) then send a pull request to https://github.com/docker-library/official-images to get the https://github.com/docker-library/official-images/blob/master/library/node file updated.

We could probably figure out a Jenkins job to automate updating the Docker files, but the PR step would probably still need to be manual.

[mhdawson]

Thanks will take a look at you have pointed me at to see what it might take to add PPC le

[mhdawson]

Still on our todo list, just have not gotten to this yet.

[xobs]

The former armhf organization hosted an armhf image at https://hub.docker.com/r/armhf/node/ that now says to use "arm32v7/node" or "arm64v8/node", but neither of these exist. I believe this is related to this issue.

The "armhf" organization was deprecated in May in favor of "arm32v7" and "arm64v8".

[tianon]

See znc/znc-docker#3 (comment) for a good comment I made over to the znc folks about supporting multiple architectures officially in official-images (yes, we're finally getting close to that!).

Some useful links:

• Support manifest lists / manifest-tool docker-library/official-images#2289 - manifest lists tracking issue (for bringing everything together under /_/...)
• https://github.com/docker-library/official-images/blob/bdc1d6c3f9b08151cfa37a1070ec384b83765fb8/README.md#multiple-architectures - development/library/node update considerations
• https://github.com/docker-library/official-images/blob/bdc1d6c3f9b08151cfa37a1070ec384b83765fb8/library/golang - an example of how this looks for Go (which is built similarly to Node in that it's consuming binaries provided directly by the upstream project)
  • see also https://github.com/docker-library/golang/blob/e72fd691a065bfec94de67bf826e4ebe511c4d24/1.8/Dockerfile#L16-L26 for how that ends up looking in the Dockerfile itself
• https://github.com/tianon/jenkins-groovy/blob/a3a4bc4db3af3f65c4a318a86bb3d5acc0b9dd83/dsl/docker-multiarch/images/node.groovy#L30-L43 - my previous hacks for making this work for Node 😇 (happy to turn that into a PR if it's something of interest)

The approach we took with Go is to have a file (https://github.com/docker-library/golang/blob/e72fd691a065bfec94de67bf826e4ebe511c4d24/1.8/release-architectures) which documents the supported architectures for each version (since it might change over time, such as how they added arm64 support in their 1.9beta1 release), and documents the mappings between bashbrew's arch (for putting the right values in library/golang), dpkg's arch (for detection), and the "upstream" arch (for actually downloading the right bits). This way we have a single file which is the "source of truth" for supported arches, and the full set of mappings between all the variations of them we need to support (and ./update.sh and ./generate-stackbrew-library.sh do the hard work).

[yhwang]

May I work on this issue?
I will start from @tianon 's suggestions. I will also follow the conventions for building multi-architecture docker images, i.e. single Dockerfile for multi-architecture.

[yhwang]

One question: for the default Dockerfile, any reason to use buildpack-deps? and how about ubuntu?

[sam-github]

@nodejs/docker see above question -----^

[yhwang]

My PR for this issue #452

[yhwang]

Another PR to generate Architectures information to support multi-arch.

[SimenB]

@yhwang this should be available now, can you verify?

[yhwang]

@SimenB I saw the amd64 images are there. However, ppc64le images are not there yet. Let me post question in the PR. Or maybe they should be somewhere else. Thanks for the notification.

[yhwang]

hooray!! I saw the images for ppc64le here

Thanks all! Thanks for your comments, reviews, suggestion and changes to make this happen! yeah!