test/parallel/test-fs-error-messages fails if tmpdir on different mount than tests

[drewfish]

• Version: v10.6.0
• Platform:
• Subsystem: test/parallel/test-fs-error-messages

When the NODE_TEST_DIR env var is set to a temporary directory which is on a different filesystem, test/parallel/test-fs-error-messages "rename non-empty directory" subtest will fail with err.code EXDEV. However the test code is written to assume this is EPERM so the assertion fails.

[drewfish]

If it's helpful I can attempt a patch for this (should be pretty easy).

[richardlau]

Does #21552 address this for you?

[drewfish]

Looking at the diff I think it will.

[aduh95]

My PR landed in b75bde3, has it resolved your issue?

[drewfish]

Yep works well. I cherry-picked b75bde3 onto the v10.6.0 tag and my build & tests worked fine.

[richardlau]

Fixed in v10.7.0.

[drewfish]

Unfortunately I'm seeing this again, starting with v11.2.0 (v11.1.0 is OK):

AssertionError [ERR_ASSERTION]: Expect EXDEV: cross-device link not permitted, rename '/tmp/screwdriver/.tmp.14/non-existent' -> 'foo' to match /ENOENT: no such file or directory, rename '\/tmp\/screwdriver\/\.tmp\.14\/non\-existent' \-\> '.*foo'/

I think it's because of the fs.rename(nonexistentFile, 'foo', ...) call:
https://github.com/nodejs/node/blob/v11.x/test/parallel/test-fs-error-messages.js#L302

I suspect that fs.rename(nonexistentFile, path.join(tmpdir.path, 'foo'), ...) might work better. I can open a PR if that helps.

[richardlau]

I suspect that fs.rename(nonexistentFile, path.join(tmpdir.path, 'foo'), ...) might work better. I can open a PR if that helps.

Please do.