Skip to content

Fix the externally loaded builtins build #39090

Closed
@mmomtchev

Description

@mmomtchev
  • Version: 17 current
  • Platform: Linux
  • Subsystem: build

What steps will reproduce the bug?

./configure --node-builtin-modules-path $(pwd)
make -j4

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Builds

What do you see instead?

../src/node_native_module.cc: In member function ‘v8::MaybeLocal<v8::String> node::native_module::NativeModuleLoader::LoadBuiltinModuleSource(v8::Isolate*, const char*)’:
../src/node_native_module.cc:211:29: error: ‘SPrintF’ was not declared in this scope
  211 |     const std::string buf = SPrintF("Cannot read local builtin. %s: %s \"%s\"",
      |                             ^~~~~~~
make[1]: *** [libnode.target.mk:384: /home/mmom/src/node/out/Release/obj.target/libnode/src/node_native_module.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:110: node] Error 2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions