Skip to content

[8.x] backport node.cc changes #21798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[8.x] backport node.cc changes #21798

wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 13, 2018

8.x backports for #20917, #21105, and #21112

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnell jasnell added the v8.x label Jul 13, 2018
@nodejs-github-bot
Copy link
Collaborator

@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/267/pipeline

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jul 13, 2018
@jasnell
Copy link
Member Author

jasnell commented Jul 13, 2018

/cc @targos @addaleax

@jasnell
Copy link
Member Author

jasnell commented Jul 13, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/15863/

@addaleax
Copy link
Member

#21105 needs to be backported to v10.x first :/

@jasnell
Copy link
Member Author

jasnell commented Jul 13, 2018

#21105 needs to be backported to v10.x first :/

That's next on my list :-)

@MylesBorins MylesBorins added the blocked PRs that are blocked by other issues or PRs. label Jul 13, 2018
@MylesBorins
Copy link
Contributor

blocking until this lands in 10.x

@MylesBorins
Copy link
Contributor

ci: https://ci.nodejs.org/job/node-test-pull-request/16102/

MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
@jasnell @MylesBorins
src: refactor bootstrap to use bootstrap object
6390d7f 
Backport-PR-URL: #21798
PR-URL: #20917
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
@jasnell @MylesBorins
src: add node_process.cc
c127df4 
Begin moving `process` object function definitions out of
`node.cc` ... continuing the process of making `node.cc`
smaller and easier to maintain.

Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Backport-PR-URL: #21798
PR-URL: #21105
MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
@jasnell @MylesBorins
src: add node_encoding.cc
f019057 
Continue moving bits of code out of node.cc ... add node_encoding.cc
as a home for `ParseEncoding` and related functions.

Backport-PR-URL: #21798
PR-URL: #21112
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 5026ab4...f019057

@MylesBorins MylesBorins closed this Aug 1, 2018
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@jasnell @rvagg
src: refactor bootstrap to use bootstrap object
54ea1cc 
Backport-PR-URL: #21798
PR-URL: #20917
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@jasnell @rvagg
src: add node_process.cc
0321afe 
Begin moving `process` object function definitions out of
`node.cc` ... continuing the process of making `node.cc`
smaller and easier to maintain.

Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Backport-PR-URL: #21798
PR-URL: #21105
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@jasnell @rvagg
src: add node_encoding.cc
eaf99d9 
Continue moving bits of code out of node.cc ... add node_encoding.cc
as a home for `ParseEncoding` and related functions.

Backport-PR-URL: #21798
PR-URL: #21112
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @nodejs-github-bot @addaleax @MylesBorins @targos