Skip to content

Benchmark by group #26558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Benchmark by group #26558

wants to merge 5 commits into from

Conversation

BeniCheni
Copy link
Contributor

@BeniCheni BeniCheni commented Mar 10, 2019

Resolves #26425

  • Implement the byGroup benchmark config option
  • Add an example with buffer-from-by-group.js benchmark
  • Update writing-and-running-benchmarks.md to mention the byGroup option:
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
example in "buffer-from-by-group.js" benchmark
const bench = common.createBenchmark(main, {
  groupA: {
    source: [
      'array',
      'arraybuffer',
      'arraybuffer-middle',
      'buffer',
      'uint8array',
      'string',
      'string-utf8',
      'string-base64',
      'object',
    ],
    len: [10, 2048],
    n: [2048]
  },
  groupB: {
    source: [
      'buffer',
      'string',
    ],
    len: [2048],
    n: [2048]
  }
}, { byGroup: true });

@BeniCheni
Copy link
Contributor Author

Closing this draft PR from a test. Sorry about the tiny noise.

@BeniCheni BeniCheni closed this Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant