util: use Set to store deprecation codes #28113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
addaleax
approved these changes
Jun 6, 2019
There was a problem hiding this comment.
I’m assuming this doesn’t have any impact on snapshotting but /cc @joyeecheung just to be sure.
|
@addaleax the same file already includes a Set const experimentalWarnings = new Set(); |
targos
approved these changes
Jun 6, 2019
cjihrig
approved these changes
Jun 6, 2019
trivikr
approved these changes
Jun 6, 2019
joyeecheung
approved these changes
Jun 7, 2019
There was a problem hiding this comment.
Thanks for the ping @addaleax . This does not really affect snapshotting - we have more places that use Map and Set during bootstrap, adding one more does not really matter since the correct solution is to implement rehashing for those instead :)
lpinca
approved these changes
Jun 7, 2019
ZYSzys
approved these changes
Jun 8, 2019
ZYSzys
added
the
author ready
Trott
approved these changes
Jun 8, 2019
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 9, 2019
PR-URL: nodejs#28113 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 0c1fd20 |
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
PR-URL: #28113 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses Set over Object to store deprecation codes.
make -j4 test(UNIX), orvcbuild test(Windows) passes