test: fix Buffer OOM error message #2915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Buffers instantiate the Uint8Array in JS the error message has changed in case the allocation fails due to OOM. Tests have been updated to match.
trevnorris
added
buffer
Fishrock123
added
build
trevnorris
added
buffer
Fishrock123
removed
buffer
|
LGTM if CI is happy |
trevnorris
added
buffer
|
LGTM |
|
Thanks all. Landed in 71c53b6. |
trevnorris
added a commit
that referenced
this pull request
Sep 16, 2015
Now that Buffers instantiate the Uint8Array in JS the error message has changed in case the allocation fails due to OOM. Tests have been updated to match. PR-URL: #2915 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
trevnorris
added a commit
that referenced
this pull request
Sep 16, 2015
Now that Buffers instantiate the Uint8Array in JS the error message has changed in case the allocation fails due to OOM. Tests have been updated to match. PR-URL: #2915 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
landed in lts-v4.x-staging as 079a217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Buffers instantiate the Uint8Array in JS the error message has
changed in case the allocation fails due to OOM. Tests have been updated
to match.
R=@Fishrock123