doc: add r2 cloudflare instruction on release #50623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ovflowd
added
fast-track
|
Fast-track has been requested by @ovflowd. Please 👍 to approve. |
ovflowd
force-pushed
the
doc-cloudflare-release-workflows
branch
from
0b03c59 to
189bef4
Compare
|
What is the long term plan for making this automated? |
|
The idea is to create a workflow on |
MoLow
approved these changes
Nov 8, 2023
tniessen
reviewed
Nov 8, 2023
ovflowd
changed the title
Done, afaik squashing will use the PR title, right? |
ovflowd
force-pushed
the
doc-cloudflare-release-workflows
branch
from
887757b to
85ea028
Compare
Update doc/contributing/releases.md Co-authored-by: Tobias Nießen <[email protected]>
ovflowd
force-pushed
the
doc-cloudflare-release-workflows
branch
from
85ea028 to
1915c04
Compare
MoLow
reviewed
Nov 8, 2023
|
|
||
| For now, after a release is done, the symlinks need to be updated manually. | ||
| This can be done by simply | ||
| [triggering this GitHub Worfklow](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/update-links.yml). |
There was a problem hiding this comment.
Suggested change
| [triggering this GitHub Worfklow](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/update-links.yml). | |
| [triggering this GitHub Worfklow](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/update-links.yml), and then [deploying](https://github.com/nodejs/release-cloudflare-worker/actions/workflows/deploy.yml) the update |
There was a problem hiding this comment.
Is the manual deployment really needed? Doesn't the sync already deploy it?
There was a problem hiding this comment.
we can add that to the sync workflow, but it currently only opens a PR
It does? That would be news to me, but might be! |
IIRC It does not node/tools/actions/commit-queue.sh Line 52 in fd4a305 |
jasnell
approved these changes
Nov 11, 2023
targos
added a commit
to targos/node
that referenced
this pull request
Nov 13, 2023
|
Automation: #50710 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
added a commit
that referenced
this pull request
Nov 23, 2023
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
Refs: nodejs#50623 PR-URL: nodejs#50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
Refs: #50623 PR-URL: #50710 Reviewed-By: Claudio Wunder <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply updates the Release Documentation with a temporary instruction set for updating the symlinks on the Cloudflare R2 Workers.