-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
fix: Console.log to console.error #58369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58369 +/- ##
==========================================
- Coverage 90.24% 90.22% -0.02%
==========================================
Files 633 633
Lines 186860 186860
Branches 36675 36674 -1
==========================================
- Hits 168623 168596 -27
- Misses 11035 11058 +23
- Partials 7202 7206 +4 🚀 New features to boost your workflow:
|
@@ -175,7 +175,7 @@ async function init() { | |||
|
|||
init(); | |||
|
|||
// Exiting gracefully to avoid stdout/stderr getting written after | |||
// Exiting gracefully to avoid stderr/stderr getting written after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't sound right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove
watch: print diagnostics messages to stderr instead of stdout
This fixes an issue where watch mode diagnostics were being printed to
stdout, which could interfere with the actual output of programs that
use stdout for their normal output. According to convention, diagnostic
and status messages should be directed to stderr.
Fixes: #56478