assert: remove dead code #58760
Open
assert: remove dead code #58760
+1
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
kt3k
commented
Jun 19, 2025
| @@ -199,7 +198,7 @@ function getErrMessage(message, fn) { | |||
| // errors are handled faster. | |||
| if (errorStackTraceLimitIsWritable) Error.stackTraceLimit = 0; | |||
|
|
|||
| if (filename) { | |||
There was a problem hiding this comment.
There is if (filename) { ... } else { return ... } structure above, and this check is unnecessary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58760 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.01%
==========================================
Files 639 639
Lines 188192 188184 -8
Branches 36911 36911
==========================================
- Hits 169634 169608 -26
- Misses 11287 11318 +31
+ Partials 7271 7258 -13
🚀 New features to boost your workflow:
|
legendecas
approved these changes
Jun 19, 2025
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Jun 19, 2025
lpinca
approved these changes
Jun 19, 2025
| @@ -199,7 +197,7 @@ function getErrMessage(message, fn) { | |||
| // errors are handled faster. | |||
| if (errorStackTraceLimitIsWritable) Error.stackTraceLimit = 0; | |||
|
|
|||
| if (filename) { | |||
| { | |||
There was a problem hiding this comment.
I think this and the ending } on 218 can be removed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codevariable ingetErrMessageutil is not initialized anymore since this commit 43c380e and the handling of it is now dead code. This PR removes them.