deps: V8: cherry-pick 0ce2edb7adfd #58773
Open
+3
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
Fix invalid template specialization
Bug: chromium:40565911
Change-Id: If206c140e99e24a6df4ee7351e8022748eabac22
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6491420
Auto-Submit: Bruno Pitrus <[email protected]>
Commit-Queue: Jakob Linke <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Reviewed-by: Jakob Linke <[email protected]>
Cr-Commit-Position: refs/heads/main@{#99987}
Refs: v8/v8@0ce2edb
Fixes: nodejs#58485
|
Review requested:
|
nodejs-github-bot
added
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@0ce2edb
Fixes: #58485
This PR fixes build error on riscv64 with gcc compiler(#58485).
This PR needs to be picked into v24.x.
Note that this PR will conflict with #58746. I will rebase #58746 once this one is merged.