-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
repl: improve tab completion on computed properties #58775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
repl: improve tab completion on computed properties #58775
Conversation
// Handle variable member lookup. | ||
// We support simple chained expressions like the following (no function | ||
// calls, etc.). That is for simplicity and also because we *eval* that | ||
// leading expression so for safety (see WARNING above) don't want to | ||
// eval function calls. | ||
// | ||
// foo.bar<|> # completions for 'foo' with filter 'bar' | ||
// spam.eggs.<|> # completions for 'spam.eggs' with filter '' | ||
// foo<|> # all scope vars with filter 'foo' | ||
// foo.<|> # completions for 'foo' with filter '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I'm removing this comment since I think that it is inaccurate (and as a consequence misleading), since various type of lines pass through here, like for example { a: true }
I think/hope that the code structure makes it clear enough what this else if
block is for (I also have half a mind to do some refactoring to also make things clearer later on 🤔)
b502583
to
fdfdac0
Compare
improve the tab completion capabilities around computed properties by replacing the use of brittle and error prone Regex checks with more robust AST based analysis
fdfdac0
to
1398800
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58775 +/- ##
==========================================
- Coverage 90.13% 90.09% -0.04%
==========================================
Files 640 640
Lines 188294 188399 +105
Branches 36923 36945 +22
==========================================
+ Hits 169712 169747 +35
- Misses 11304 11354 +50
- Partials 7278 7298 +20
🚀 New features to boost your workflow:
|
improve the tab completion capabilities around computed properties by replacing the use of brittle and error prone Regex checks with more robust AST based analysis
Followup from #58709