feat: enable remark-lint-no-literal-urls #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream PR to fix nodejs/node#32676
nschonni
force-pushed
the
enable-remark-lint-no-literal-urls
branch
from
56e1f94 to
645f345
Compare
Trott
approved these changes
Apr 24, 2020
|
This doesn't result in a change to package-lock.json? |
|
I think there is no lock file change, because the rule is used by the recommended package. We just install these on top to be able to override them |
Yeah, I would have thought the lock file format would still have a metadata change, but I guess not.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream PR to fix nodejs/node#32676