Skip to content

Update DNS caching example to include other interceptors, production configuration #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

GeoffreyBooth
Copy link
Member

Resolves #4120 (comment). Updates the DNS caching example to use Undici’s own DNS interceptor rather than recommending an external library; and adds the retry and response caching interceptors to make the example more representative of a typical production configuration. cc @mcollina

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 67adf42 into nodejs:main Mar 31, 2025
28 of 31 checks passed
@GeoffreyBooth GeoffreyBooth deleted the production-configuration branch March 31, 2025 14:34
@github-actions github-actions bot mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DNS caching example?
4 participants