-
Notifications
You must be signed in to change notification settings - Fork 663
Extra stream kinds #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Extra stream kinds #1928
Conversation
Seems like |
Looks good. But I would change the Raid kind to remove the markers and add those as tag names directly. |
Needs to be indexed so i used |
You can change "tags": [
["f", "30311:<Community event author pubkey>:<d-identifier of the community>", "<Optional relay url>"],
["t", "30311:<Community event author pubkey>:<d-identifier of the community>", "<Optional relay url>"],
], So you can filter by incoming and outgoing |
@vitorpamplona true but then i cant include only the kind in a relay filter which already fetches chat messages for example and i need another 2 filters to load raids |
Kind 30312 and 30313 are already in use on Hivetalk. We have been actively publishing kind 30312 for Hivetalk rooms since approximately February 2025 Kind 30312 has been active for the last few months on 3 relays: Kind 30313 active on: please also see open PR for NIP53 addendum here: |
@v0l, @bitkarrot and I have been working on migrating Nests and Hivetalk (per @fiatjaf) to a compatible kind for interoperability. She has all of her Hivetalk changes live and has for a couple months. I haven't updated Nests yet, but I will be doing that tomorrow. See her linked PR. Your proposed changes will give us collisions, so we should sort this out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how simple this is and that it only extends the live stream chat functionality without adding any more complexity to the live stream event itself
["r", "https://example.com/my-clip.mp4"], | ||
["title", "Streamer gets rekt by bot!"] | ||
], | ||
"content": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the content
set my the user or left blank? It might be good to mention this since it could effect how apps create and display clips
|
||
### Stream Timeout | ||
|
||
Event `kind:1314` is a live chat moderation event that temporarily mutes a user from chatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the right approach for moderation instead of the host having to update their k:10000 mute list
Is there any merit in having an optional a
tag that restricts the timeout to a specific stream?
This also could make it possible for the host to designate moderator pubkeys for their streams, but that it out of scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any merit in having an optional a tag that restricts the timeout to a specific stream?
Maybe we could add that, but i think in 90% of cases you would just timeout based only on time, so if somebody is really rude you would do a timeout for 1 week for example and you would want to timeout them regardless of which stream, then in other cases a 30min timeout, the streamer knows how long their own stream is and can do the timeout without tagging the stream.
This also could make it possible for the host to designate moderator pubkeys for their streams, but that it out of scope of this PR
yea i want to add this in another PR, to create moderators pubkey set
"kind": 1312, | ||
"tags": [ | ||
["a", "30311:<Community event author pubkey>:<d-identifier of the community>", "<Optional relay url>", "from"], | ||
["a", "30311:<Community event author pubkey>:<d-identifier of the community>", "<Optional relay url>", "to"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO using a different single letter tag is a better solution than using a "label" at the end of the tag. things always seem to get messy when arbitrary strings are added to tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok how about just using the order then?
Adding extra events used currently by zap.stream
https://github.com/v0l/zap.stream/blob/3f587ab885a7f3580b3164334dfc192d53829b1a/src/const.ts#L3-L6
https://github.com/nostrlabs-io/zap-stream-flutter/blob/f8f5860b643dcb0ec1928fde91fd3dd7e2371117/lib/widgets/chat.dart#L29
nostrlabs-io/zap-stream-flutter#13