Fix broken NPM bundle by publishing in ES-Module format #1958
+24
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
|
Please don't open a new PR as that means it is more difficult to see all the context. You can just adjust the existing one with your changes. |
|
@CendioOssman sadly github does not allow changing the head branch of the PR. Your request is to history-rewrite my original PRs head (master)? I can do that but for me it makes it more difficult to understand the context in the future. |
|
Yeah I literally can't reopen the other PR or this one. |
|
Continue here then, strange behavior by GitHub.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1943
Repeat of #1944 with different head branch
Testable by placing
"@novnc/novnc": "npm:@elikoga/[email protected]",inpackage.jsonUses
exportsinpackage.jsonto make sure that old imports still workThis one incorporates the review requests in the previous PR by simply dropping the conversion step using babel.
CI Passes in my repo