Skip to content

feat(angular-rspack): use development config for serve #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

Coly010
Copy link
Collaborator

@Coly010 Coly010 commented Apr 28, 2025

Current Behaviour

The createConfig function will default to production when NGRS_CONFIG is not provided.
This includes for launching the dev server.

Expected Behaviour

When running rspack serve the createConfig should default to development.

Copy link

nx-cloud bot commented Apr 28, 2025

View your CI Pipeline Execution ↗ for commit dc4c6b7.

Command Status Duration Result
nx-cloud record -- pnpm check-commit ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-28 12:46:14 UTC

@Coly010 Coly010 force-pushed the defaul-dev-config-serve branch from 2148eb0 to a80650d Compare April 28, 2025 10:28
@Coly010 Coly010 force-pushed the defaul-dev-config-serve branch from a80650d to dc4c6b7 Compare April 28, 2025 12:43
@Coly010 Coly010 merged commit 7ba87d1 into main Apr 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant