feat(angular-rspack): add watch option

e2e/fixtures/rspack-csr-css/rspack.config.js

@@ -63,6 +63,7 @@ module.exports = () => {
           baseHref: '/foo',
           subresourceIntegrity: true,
           crossOrigin: 'anonymous',
+          watch: false, // Set to true when testing watch mode
         },
       },
       {

packages/angular-rspack/src/lib/config/config-utils/common-config.ts

@@ -1,5 +1,5 @@
-import { type Configuration, javascript } from '@rspack/core';
-import { resolve } from 'node:path';
+import { type Compiler, type Configuration, javascript } from '@rspack/core';
+import { join, resolve } from 'node:path';
 import {
   JS_ALL_EXT_REGEX,
   TS_ALL_EXT_REGEX,
@@ -15,6 +15,7 @@ import { configureSourceMap } from './sourcemap-utils';
 import { StatsJsonPlugin } from '../../plugins/stats-json-plugin';
 import { getStatsOptions } from './get-stats-options';
 import { WatchFilesLogsPlugin } from '../../plugins/watch-file-logs-plugin';
+import { getIndexInputFile } from '../../utils/index-file/get-index-input-file';
 
 export async function getCommonConfig(
   normalizedOptions: NormalizedAngularRspackPluginOptions,
@@ -30,6 +31,17 @@ export async function getCommonConfig(
     hashFormat,
     normalizedOptions.hasServer ? 'server' : 'browser'
   );
+  const indexInputFile = join(
+    normalizedOptions.root,
+    getIndexInputFile(normalizedOptions.index)
+  );
+  const indexInputWatchPlugin = {
+    apply: (compiler: Compiler) => {
+      compiler.hooks.thisCompilation.tap('build-angular', (compilation) => {
+        compilation.fileDependencies.add(indexInputFile);
+      });
+    },
+  };
 
   const defaultConfig: Configuration = {
     context: normalizedOptions.root,
@@ -68,6 +80,7 @@ export async function getCommonConfig(
     resolveLoader: {
       symlinks: !normalizedOptions.preserveSymlinks,
     },
+    watch: normalizedOptions.watch,
     watchOptions: {
       poll: normalizedOptions.poll,
       followSymlinks: normalizedOptions.preserveSymlinks,
@@ -125,6 +138,7 @@ export async function getCommonConfig(
     plugins: [
       ...sourceMapOptions.sourceMapPlugins,
       ...(normalizedOptions.verbose ? [new WatchFilesLogsPlugin()] : []),
+      ...(normalizedOptions.watch ? [indexInputWatchPlugin] : []),
       ...(normalizedOptions.statsJson
         ? [
             new StatsJsonPlugin(

packages/angular-rspack/src/lib/config/create-config.unit.test.ts

@@ -178,21 +178,21 @@ describe('createConfig', () => {
         createConfig({
           options: {
             ...configBase,
-            watch: true,
+            appShell: true,
             devServer: { allowedHosts: ['localhost'] },
           },
         })
       ).resolves.not.toContain([
         expect.objectContaining({
-          watch: true,
+          appShell: true,
           devServer: expect.objectContaining({
             allowedHosts: ['localhost'],
           }),
         }),
       ]);
       expect(warnSpy).toHaveBeenCalledWith(
         `The following options are not yet supported:
-  "watch"
+  "appShell"
 `
       );
     });

packages/angular-rspack/src/lib/models/angular-rspack-plugin-options.ts

@@ -119,6 +119,11 @@ export interface SourceMap {
 }
 
 export interface AngularRspackPluginOptions extends PluginUnsupportedOptions {
+  /**
+   * @deprecated This is a no-op and can be safely removed.
+   * A list of CommonJS or AMD packages that are allowed to be used without a build time warning. Use `'*'` to allow all.
+   */
+  allowedCommonJsDependencies?: string[];
   aot?: boolean;
   assets?: AssetElement[];
   /**
@@ -250,6 +255,10 @@ export interface AngularRspackPluginOptions extends PluginUnsupportedOptions {
    * Adds more details to output logging.
    */
   verbose?: boolean;
+  /**
+   * Run build when files change.
+   */
+  watch?: boolean;
   /**
    * @deprecated This is a no-op and can be safely removed.
    * The tsconfig file for web workers.
@@ -288,4 +297,5 @@ export interface NormalizedAngularRspackPluginOptions
   supportedBrowsers: string[];
   tsConfig: string;
   vendorChunk: boolean;
+  watch: boolean;
 }

packages/angular-rspack/src/lib/models/normalize-options.ts

@@ -297,6 +297,7 @@ export async function normalizeOptions(
     useTsProjectReferences: options.useTsProjectReferences ?? false,
     vendorChunk: options.vendorChunk ?? false,
     verbose: options.verbose ?? false,
+    watch: options.watch ?? false,
   };
 }
 

packages/angular-rspack/src/lib/models/unsupported-options.ts

@@ -28,18 +28,11 @@ export interface DevServerUnsupportedOptions {
 }
 
 export interface PluginUnsupportedOptions {
-  watch?: boolean;
   budgets?: BudgetEntry[];
-  allowedCommonJsDependencies?: string[];
   appShell?: boolean;
 }
 
-export const TOP_LEVEL_OPTIONS_PENDING_SUPPORT = [
-  'watch',
-  'budgets',
-  'allowedCommonJsDependencies',
-  'appShell',
-];
+export const TOP_LEVEL_OPTIONS_PENDING_SUPPORT = ['budgets', 'appShell'];
 
 export const DEV_SERVER_OPTIONS_PENDING_SUPPORT = [
   'open',

packages/angular-rspack/src/lib/utils/index-file/get-index-input-file.ts

@@ -0,0 +1,9 @@
+import type { IndexExpandedDefinition } from '../../models';
+
+export function getIndexInputFile(index: IndexExpandedDefinition): string {
+  if (typeof index === 'string') {
+    return index;
+  }
+
+  return index.input;
+}