JestBuilder not respect globals properties defined in jest.config.js

[kklimczak]

Expected Behavior

Properties defined in globals property inside jest.config.js should be available in jest context.

Current Behavior

At this moment globals is ignored because here JestBuilder set own globals settings so Jest ignores settings from jest.config.js.
This behavior occures when I run tests via ng test. When I run as jest or inside WebStorm IDE tests work fine.

Failure Information (for bugs)

I set enableTsDiagnostics property to enable type-checking inside my tests, but it's not work.

Steps to Reproduce

1. Init nx workspace with cli,
2. Add test lib,
3. Add class (g.e. test) to lib with one param in costructor,
4. Create spec file for above class and call constructor without param.
5. Run tests via ng test.

Context

Please provide any relevant information about your setup:

• version of Nx used - 7.5.1
• version of Angular CLI used - 7.2.4
• angular.json configuration
• version of Angular DevKit used - 0.11.2
• 3rd-party libraries and their versions -> package.json
• and most importantly - a use-case that fails

I prepare repo with bug reproduction. In my case I'd like to enable type checking in ts-jest so I need to set enableTsDiagnostics flag to true.

[rweng]

same problem here. I want to set skipBabel: true because otherwise I have problems with default imports. It works if I insert it directly to the runCLI command line options, here

nx/packages/builders/src/jest/jest.builder.ts

Lines 50 to 55 in 2ce53ea

	globals: JSON.stringify({
	'ts-jest': {
	tsConfigFile: path.relative(builderConfig.root, options.tsConfig)
	},
	__TRANSFORM_HTML__: true
	})

In case anyone else has the exact problem as me: until it is possible to configure the globals in the builder, a workaround is to add the following to the package.json

"jest": {
    "globals": {
      "ts-jest": {
        "skipBabel": true
      }
    }
  },

and then running jest --clearCache

[kklimczak]

I noticed that when I comment:

nx/packages/builders/src/jest/jest.builder.ts

Lines 50 to 55 in 2ce53ea

	globals: JSON.stringify({
	'ts-jest': {
	tsConfigFile: path.relative(builderConfig.root, options.tsConfig)
	},
	__TRANSFORM_HTML__: true
	})

jest fetch globals from jest.config.js correctly.

[mohyeid]

Same issue I am facing here while trying to migrate to jest-preset-angular alpha-2, some new configurations needed to be set in the globals and the builder override it. globals need to be extensible. #thymikee/jest-preset-angular#217

[kklimczak]

Instead of defining globals here:

nx/packages/builders/src/jest/jest.builder.ts

Lines 50 to 55 in 2ce53ea

	globals: JSON.stringify({
	'ts-jest': {
	tsConfigFile: path.relative(builderConfig.root, options.tsConfig)
	},
	__TRANSFORM_HTML__: true
	})

cli will generate this lines inside jest.config.ts?

[lonix1]

Hey guys there are many issues lately which seem unrelated but they are - nx isn't playing nice with jest-preset-angular and so tests don't work.

Can someone share a working config: jest.config.js and tsconfig.spec.json, etc.?

[FrozenPandaz]

I'd like to get this to work as well.

The reason it does not work is that jestCLI node api seems to take a stringified json which means the whole globals input is overwritten. We only need to overwrite the tsConfig property of ts-jest. Does anybody have an idea of how this could work?

[lonix1]

Hey @FrozenPandaz Thanks for looking into this, we've been going round in circles for days. Some of the stuff we've tried:

1. I had a hunch nx was using the old APIs, so I did this:

  globals: {
    'ts-jest': {
      tsConfig: './tsconfig.spec.json',
      tsConfigFile: './tsconfig.spec.json',
    }
  }

I thought that would force it to work with the old AND new APIs, but sadly that doesn't work either. So it's probably not an API thing.

2. I tried the workaround here to use a common config for all apps in the workspace. But that doesn't help either. It gets us some of the way, but something under the covers is still overriding config. So we swap one set of errors for another.

3. I tried adding the config to package.json and then to jest.config.js in the hope it was a race condition in the way the config is applied, but that didn't work.

[lonix1]

The stringification may not be a problem - see the migration notes for jest-preset-angular.

The globals should be overridable, I think that's how the preset does it (override/extend rather than replace).

[mohyeid]

@lonix1
What you can do to get this work in your local is open the jest.builder.js file and add the required configuration there. Builder will keep overriding your configuration if you place them in the jest.config file. So to persist them go to node_modules@nrwl\builders\src\jest\jest.builder.js and change the globals to the following:

globals: JSON.stringify({
        'ts-jest': {
          tsConfigFile: path.relative(builderConfig.root, options.tsConfig),
		  stringifyContentPathRegex: '\\.html$',
		  astTransformers: ['jest-preset-angular/InlineHtmlStripStylesTransformer']
        },
        __TRANSFORM_HTML__: true

If you want this to work in your build server, this is another story as you have to download the tar file for @nrwl/builders and patch it, then use your local version for installation. Let me know if you need help with this.

[lonix1]

@mohyeid Thanks... Do you mean this line? Nope that doesn't work for me I still can't get tests to run. Maybe we are using different versions, or different config files. I also tried commenting out the stuff mentioned in the posts above.

Hopefully if someone gets this to work, we can get a set of working configs that we can look at. Or a minimal sample repo.

[mohyeid]

@lonix1
I am not sure what version you are in, but the line you sent is off master branch which seems to have the fix that we are trying to do. As I am in 7.1.1 this code was not there and this is why I have to patch it.

[lonix1]

I'm on the latest version.

npx nx --version     # 7.7.2

Version 7.1.1 that you're using is "ancient" in that many bugs have been fixed since then. Is there a reason you're still using it? Anyways, unfortunately, even using the latest doesn't resolve the issue. :(