-
Notifications
You must be signed in to change notification settings - Fork 111
Initial draft for triaging #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I will automatically update this comment whenever this PR is modified
|
Nice work! Will look more closely this week. Looks like there's a tradeoff to be considered here to fix linting with |
I'm wondering if some updates may be needed based on the recently closed #760 ? If it would be helpful for me to review and update accordingly, I'd be happy to help. |
@asteiker that would be super helpful!! |
@asteiker OK to assign this PR to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌 Amazing work! Sorry about the number of suggestions here -- we re-organized labels in #760 to be more self-describing, and I think that helps make this document more clear!
@asteiker can you also take a look? |
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
Co-authored-by: Matt Fisher <[email protected]>
@Sherwin-14 how are you feeling about the next steps for this PR? |
I was waiting for the next hackday to start working on this again. I believe collaborating on this alongside @asteiker would be the ideal path forward. We can list all the areas where improvements are needed, in that way I would also get an idea about what steps I need to take moving forward. I had individual reviews from you and Amy, but I feel collaborating together on this coming hackday would make it easier to keep a track of suggestions and improvements. |
@Sherwin-14 Yes, let's finalize these open items together at the hackday. I would also like to start implementing the priority designation in the bug priority project view: earthaccess project |
Hey Amy! Could you summarize the improvements that we agreed upon on the last hackday? I do remember some of those but I guess you have a better idea about this. |
@Sherwin-14 Here is a summary of the changes remaining:
Note that I also just entered #984 and can work this asap so that the pending triage label removal step is applicable. |
Thanks @asteiker! I have a question regarding the first point. Do you want me to remove the priority labels and just preserve the tags or do you want me to remove the tags alongside priority labels. On removing priority labels and preserving the respective tags, the workflow diagram would look something like this. |
Can you clarify what you mean by "tags" here? If you mean the workflow steps (rectangles) I'm all for removing them :) |
Yeah, workflow steps are what I meant by tags. But, the workflow diagram would be incomplete without them so we might have to replace these workflow steps with something else or get rid of those Diamond Shape boxes alongside workflow steps (maybe even removing the "Unsupported markdown: list" section entirely) going forward. What do you think about this? |
@Sherwin-14 and I discussed the behavior and agree that the "Unsupported markdown: list" box should be replaced with "Confirm that "Bug" label was automatically added as part of the Bug Issue template, otherwise add "Bug" label." |
💯 I think we can remove "Does it make earthaccess unusable" and everything underneath. Let's worry about prioritization of issues when we're ready :) |
@mfisher87 I have made the changes, I think before merging we might need to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this once the pre-commit error is resolved. Thank you for your patience with this incredibly persistent task 😅
|
Nice, thanks for the fix! The |
This PR is docs-only so ignoring the integration test failures |
Thanks, @Sherwin-14 🎉 |
This is the initial draft for the triaging document(#754). The pre-commit check is failing because of the use of format argument which seems like a necessity for rendering the doc, more on this here.
📚 Documentation preview 📚: https://earthaccess--901.org.readthedocs.build/en/901/