New flash creation dialog in QML #262
Conversation
|
on macOS, I guess it's OK? (ignore the type discrepancy, I just chose the first file I came across) I'll try to test on iOS sometime soon. |
|
That said, the two list selects seem to be read-only somehow: |
|
Do they only look read-only or are they actually read-only? Might just be a weird color scheme |
|
They're actually read only. |
|
No, that makes no sense... https://doc.qt.io/qt-5/qml-qtquick-controls-combobox.html doesn't even have an Do other comboboxes in the config dialog behave similarly? |
Everything else behaves correctly |
|
Can you add this in strategic places to find what disables it? |
|
Well, I tried, and it prints this: Seems like a Qt bug on macOS then, who knows.... That said, even if the UI is messed up, tabbing to the control to get its focus, then pressing the arrow keys to select the wanted option, works fine (as long as you don't open the dropdown) |
|
OK it is a Qt Bug, but not fixed in OSS releases ... https://bugreports.qt.io/browse/QTBUG-89607 / https://forum.qt.io/topic/123101/quick-controls-1-combobox-items-unselectable-on-macos/9 |
According to that, the issue is fixed in 5.15.3. Can you try the latest 5.15.5? |
Well 5.15.5 doesn't seem to be available - it stops at 5.15.2 here... 🤔 |
Maybe they just do (pathetic) delayed source releleases but no binary ones? Annoying... |
|
Might be time to upgrade to Qt6 :P |
Vogtinator
force-pushed
the
flashdialog
branch
from
c8d5c8a to
02b9380
Compare
|
I added a workaround for the Qt bug, can you try whether that works? |
|
Some usual Qt weirdness regarding text alignment and focus oddities, but it does work :)
|
|
Were you able to test on iOS as well? |
|
Ah, no, not yet anyway, just macOS for now. |
Vogtinator
force-pushed
the
flashdialog
branch
from
02b9380 to
bde9480
Compare
A rewritten and slightly redesigned flash creation dialog in QML. This doesn't depend on QWidgets and can thus be used on Android/iOS as well. Some functions to read metadata from flash components were added to the core, they work in a less hacky way than the ones in flashdialog.cpp previously. Fixes nspire-emus#135
Those are smaller and thus fit better on screen size constrained mobile platforms and work fine on desktop as well. Also allows to create snapshot files that way.
It works just fine and tells whether the permission expired. This also means it needs to be reevaluated after reselecting files.
Declare some widths/heights correctly, fix some resizing issues.
It's a global singleton type, doesn't make sense to let QML manage it. Before this change, it was destroyed too early, causing warnings on exit like: TypeError: Cannot read property 'myData' of null
Popups in modal dialogs are broken.
Vogtinator
force-pushed
the
flashdialog
branch
from
bde9480 to
dd98cc9
Compare
For some reason the bottom anchor of the scaled Keypad doesn't work anymore.
|
tested OK on iOS |
New flash creation dialog + an Android usability improvement + QML fixes.
With this, the warnings on exit are finally gone!
@adriweb Please test whether the dialog works as expected on macOS and especially iOS as well.