change did OAS param to use content instead of schema #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
reviewed
Feb 27, 2024
gerardsn
approved these changes
Feb 28, 2024
gerardsn
requested changes
Feb 28, 2024
woutslakhorst
force-pushed
the
fix/2831/double_unescape_path
branch
from
dd61b4f to
a3cc3b2
Compare
gerardsn
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2831
when using schema oapi codegen uses
BindStyledParamWithOptionswhich does an url unescape. This is not needed since go already does this. When using port numbers in a DID this causes the:to be decoded (should remain percentage encoded)note: oapi codegen also updated to 2.1.0