refactor: extract core utilities in preparation for fontless
#627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Damián Pumar <[email protected]> Co-authored-by: jack shelton <[email protected]> Co-authored-by: gioboa <[email protected]>
Deploying fonts with
|
| Latest commit: |
fdb09df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://556ca7a2.fonts-dsw.pages.dev |
| Branch Preview URL: | https://refactor-fontless.fonts-dsw.pages.dev |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 83.79% 78.94% -4.85%
==========================================
Files 13 11 -2
Lines 1080 570 -510
Branches 305 118 -187
==========================================
- Hits 905 450 -455
+ Misses 166 116 -50
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
this extracts quite a few key utilities into a folder pending extraction into a separate library -
fontless- destined for https://github.com/unjs/fontaine.this is based on the work of Damián, Jack + Giorgio in https://github.com/QwikDev/fontless ❤️