Skip to content

feat(DropdownMenu): body slot #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mdotme
Copy link

@mdotme mdotme commented Jun 5, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added body slot for complex usecases like Drawer and Modal have one which is pretty handy.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@mdotme mdotme requested a review from benjamincanac as a code owner June 5, 2025 17:04
Copy link

pkg-pr-new bot commented Jun 5, 2025

npm i https://pkg.pr.new/@nuxt/ui@4296

commit: 332dd5a

@benjamincanac
Copy link
Member

I'm not really sure about this, doing so will loose all the advantages of the DropdownMenu. Why not use a Popover to achieve that?

@mdotme
Copy link
Author

mdotme commented Jun 11, 2025

I'm not really sure about this, doing so will loose all the advantages of the DropdownMenu. Why not use a Popover to achieve that?

That makes sense. I can't believe how I missed Popover component

@mdotme mdotme closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants