Skip to content

Use network explorer map data with disputed areas #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

@mmsinclair
Copy link
Contributor

mmsinclair commented Mar 1, 2022

@Baro1905 thanks for the PR 😀

Sadly, as you may have noticed, the data from Natural Earth Vectors used by react-simple-maps is the problem. Sadly, the 110m disputed areas map still has Crimea's geometry in Russia. So unfortunately the ne_110m_admin_0_countries.json is not any better than the regular 110m map geometry 😔

However, what I have done is to move the geometry manually inside the 110m geometry file as suggested in nvkelso/natural-earth-vector#489 (comment). The result is as follows:

image

image

@mmsinclair mmsinclair merged commit 562eb63 into develop Mar 1, 2022
@mmsinclair mmsinclair deleted the bugfix/explorer-map-data branch March 1, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants