Skip to content

Introduced disable_main_poisson_packet_distribution to force real_traffic_stream to disable poisson sending #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Oct 6, 2022

Description

#1963

Due to changes in Stream implementation, could I have some extra eyes on it? @octol @neacsu @durch

Checklist:

  • added a changelog entry to CHANGELOG.md

@jstuczyn jstuczyn requested a review from mfahampshire as a code owner October 6, 2022 13:02
@jstuczyn
Copy link
Contributor Author

jstuczyn commented Oct 7, 2022

This is currently put on hold until we figure out why it significantly increases the number of unnecessarily retransmitted packets when enabled. the problem was elsewhere.

@jstuczyn jstuczyn marked this pull request as draft October 7, 2022 09:34
@jstuczyn jstuczyn marked this pull request as ready for review October 10, 2022 08:41
@jstuczyn jstuczyn force-pushed the feature/control-poisson-sending branch from ddaf638 to 9fc953b Compare October 10, 2022 08:46
@jstuczyn jstuczyn merged commit 11a67ad into develop Oct 10, 2022
@jstuczyn jstuczyn deleted the feature/control-poisson-sending branch October 10, 2022 09:10
jstuczyn added a commit that referenced this pull request Oct 10, 2022
…ffic_stream to disable poisson sending (#1664)

* Introduced disable_main_poisson_packet_distribution to force real_traffic_stream to disable poisson sending

* Updated changelog
jstuczyn added a commit that referenced this pull request Oct 10, 2022
* Compiles but runtime time fails

* wip

* Beginning of clean-up - creation of config to keep things together

* Removed unused module

* Removed hardcoded constants

* Easier way of sending binary messages

* WIP cleanup before machine switch

* Upgrade wasm-bindgen to 0.2.83

* Fixed compilation warnings for wasm client

* all clients compiling without warnings

* disabling topology refresh in wasm

* Added a config option to disable loop cover traffic stream

* config changes

* Make webassembly work in a web worker
- `wasm-timer` modified to work in web worker
- add worker target to webpack
- add client to call from HTML
- update README to build WASM for bundling (this does not build ES modules)

* Restored topology refreshing

* correctly polling items in the wasm delay_queue

* Allow client to read up to 8 messages at once from gateway connection (#1669)

* Allow client to read up to 8 messages at once from gateway connection

* Importing tokio::select in wasm32 target

* Updated changelog

* missing imports

* Introduced disable_main_poisson_packet_distribution to force real_traffic_stream to disable poisson sending (#1664)

* Introduced disable_main_poisson_packet_distribution to force real_traffic_stream to disable poisson sending

* Updated changelog

* Adjusting default settings

* Introduced a client-configurable option to force it to use extended packet size

* local adjustments

* Removed warning associated with receiving extended packets

* Minimal v2-required changes

* Updated changelog

* explicitly allowing clippy drop_non_drop

Co-authored-by: Mark Sinclair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants