Skip to content

Introduced a client-configurable option to force it to use extended packet size #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2022
Merged

Introduced a client-configurable option to force it to use extended packet size #1671

merged 4 commits into from
Oct 10, 2022

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Oct 10, 2022 •
edited
Loading

Checklist:

  • added a changelog entry to CHANGELOG.md

octol
octol reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@octol octol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a warning when receiving an extended packet saying it was unexpected, should we keep that?

@jstuczyn
Copy link
Contributor Author

There is a warning when receiving an extended packet saying it was unexpected, should we keep that?

good point - we probably should remove it

@jstuczyn jstuczyn force-pushed the feature/configurable-packet-size branch from 921d7c4 to 4bd7752 Compare October 10, 2022 12:19
@jstuczyn jstuczyn merged commit 54d97fd into develop Oct 10, 2022
@jstuczyn jstuczyn deleted the feature/configurable-packet-size branch October 10, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octol octol octol left review comments

@aniampio aniampio Awaiting requested review from aniampio

@durch durch Awaiting requested review from durch

@futurechimp futurechimp Awaiting requested review from futurechimp

@neacsu neacsu Awaiting requested review from neacsu

@mfahampshire mfahampshire Awaiting requested review from mfahampshire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstuczyn @octol