Feature/rename nymd to nyxd #2696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futurechimp
requested review from
neacsu,
mfahampshire,
mmsinclair,
fmtabbara,
durch,
jstuczyn and
octol
as code owners
|
Ok this one is ready to have a look at. Note that the earlier renames in #1863 were missing some template changes and would fail, they're in this one (dirty but true). |
jstuczyn
force-pushed
the
feature/rename-nymd-to-nyxd
branch
2 times, most recently
from
489d65c to
bf34f5a
Compare
jstuczyn
force-pushed
the
feature/rename-nymd-to-nyxd
branch
from
bf34f5a to
cbf2d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2710
There are a lot of references to "validator" and "nymd" in the code, but:
a)
validatorcould mean either the machine or the processb)
nymdis not our validator binary name, it's beennyxdfor quite a long timeThis pull request cleans up the code to get rid of
nymdeverywhere and start to usenyxdinstead.Checklist:
CHANGELOG.md