feature: use clap derive for nym-api + use stricter validation for other binaries #2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
requested review from
aniampio,
durch,
futurechimp,
neacsu and
octol
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2757
This pull requests also updates some argument types for other binaries (such as our clients, mixnode, etc) so that
clapcould perform more validation/parsing at the time of invoking particular command. So say if you attempted to pass something that's not a validUrlfor--nym_apis, it should show you an error way sooner. (note, this particular field was previously called--api_validators; it got changed in #2762, but the old name should still be allowed)Checklist:
CHANGELOG.md