feat: validator client refactoring + wasm compatible nyxd client #3726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
force-pushed
the
feature/validator-client-housekeeping
branch
from
920b9e3 to
3ec3503
Compare
jstuczyn
force-pushed
the
feature/validator-client-housekeeping
branch
2 times, most recently
from
c836657 to
abf8363
Compare
jstuczyn
force-pushed
the
feature/validator-client-housekeeping
branch
2 times, most recently
from
e45a0c5 to
e787bf9
Compare
jstuczyn
changed the title
This was referenced Aug 15, 2023
jstuczyn
force-pushed
the
feature/validator-client-housekeeping
branch
from
85a0c70 to
35e2100
Compare
* wasm-compatible reqwest-based rpc client * better constructors for the reqwest based client * fixed usages of the client * introduced /network/details endpoint to nym-api to return used network information (#3758) * introduced /network/details endpoint to nym-api to return used network information * introduced endpoints for nym contract information
jstuczyn
force-pushed
the
feature/validator-client-housekeeping
branch
from
35e2100 to
e849dc1
Compare
jstuczyn
changed the title
tommyv1987
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a step 2 of the master plan of making our rust nyxd client fully compatible with wasm. I've refactored bunch of internal code and a result all client traits compile to wasm and so does the
DirectSecp256k1HdWallet.~~The remaining work (for step 3) would be to fully implemenent the
WasmRpcClient-> it will most likely usereqwest. ~~The remaining work (for this PR) includes dealing with all outstandingtodo!()andunimplemented!()such as implementing all queries/signing operations for the contract clients.As requested by @tommyv1987 this branch/RP now includes changes introduced in #3744 and #3758. All of them will be merged at once here.