Skip to content

standarised ContractBuildInformation and added it to all contracts #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jun 6, 2024

Description

Similarly to cw2, we're now saving ContractBuildInformation under a constant storage key, i.e. b"contract_build_info" that standarises the retrieval by nym-api.

Also each of our contracts now saves and updates that information upon init and migration.

Checklist:

  • added a changelog entry to CHANGELOG.md

@jstuczyn jstuczyn requested review from octol and durch as code owners June 6, 2024 14:54
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 11:23am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 11:23am

@tommyv1987 tommyv1987 added this to the Chomp milestone Jun 10, 2024
@jstuczyn jstuczyn force-pushed the feature/standarise-contract-info branch from 89dbe89 to f1486fb Compare June 11, 2024 11:22
@jstuczyn jstuczyn merged commit 5cbbeee into develop Jun 11, 2024
24 checks passed
@jstuczyn jstuczyn deleted the feature/standarise-contract-info branch June 11, 2024 12:43
@tommyv1987
Copy link
Contributor

Testing Completion Date: [12/06/2024]

Testing Steps Performed:

  1. Use the latest release/chomp contracts and deploy these to QA
  2. Use the nym-api to query for the results of these new contracts
curl -X 'GET' \
  'https://qa-nym-api.qa.nymte.ch/api/v1/network/nym-contracts-detailed' \
  -H 'accept: application/json'

Which returns a detailed view of the contracts and which branch they were built from, alongside rust versions and so forth.

image

Validation:

  • ✅ Test Passed
  • [ 🔴 ] Issues Found

Notes (if any):
N/A

Attachments (if applicable):
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants