Skip to content

bugfix: make sure nym-api can handle non-cw2 (or without detailed build info) compliant contracts #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jun 11, 2024

No description provided.

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Jun 11, 2024 4:39pm
nym-next-explorer ⬜️ Ignored (Inspect) Jun 11, 2024 4:39pm

@jstuczyn jstuczyn added this to the Chomp milestone Jun 11, 2024
@jstuczyn jstuczyn changed the title bugfix: make sure nym-api can handle non-cw2 (or without detailed bui… bugfix: make sure nym-api can handle non-cw2 (or without detailed build info) compliant contracts Jun 11, 2024
@jstuczyn jstuczyn merged commit 579527b into develop Jun 11, 2024
27 of 28 checks passed
@jstuczyn jstuczyn deleted the bugfix/contracts-compat branch June 11, 2024 17:04
@tommyv1987
Copy link
Contributor

Testing Completion Date: [12/06/2024]

Testing Steps Performed:

  1. Use the latest release/chomp contracts and deploy these to QA
  2. If the contract was not found, the API would complain of invalid contracts, thus not starting the rest of the operations of the API (network monitor / rewarding etc)

Jun 11 16:27:34 qa-v2-nym-api bash[1352642]: 2024-06-11T16:27:34.551Z ERROR nym_api::nym_contract_cache::cache::refresher > Failed to refresh validator cache - Abci query failed with code 6 - address n14y2x8a60knc5jjfeztt84kw8x8l5pwdgnqg256v0p9v4p7t2q6eswxyusw: no such contract: unknown request

This fixes the issue (even if some contracts aren't uploaded on chain it doesn't prohibit the api from working - caveat, the essential vesting and mixnet contract are required)

Validation:

  • ✅ Test Passed
  • [ 🔴 ] Issues Found

Notes (if any):
N/A

Attachments (if applicable):
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants