Skip to content

Move NS client to separate package under NS API #5171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

dynco-nym
Copy link
Contributor

@dynco-nym dynco-nym commented Nov 22, 2024

  • moving NS API client code to separate package outside NS Agent makes the code cleaner & more modular
  • NS agent now imports NS API client that it uses
  • no functionality change in NS API or NS agent

This change is Reviewable

@dynco-nym dynco-nym requested review from octol and jstuczyn November 22, 2024 17:01
@dynco-nym dynco-nym self-assigned this Nov 22, 2024
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 1:58pm
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 1:58pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 1:58pm

@dynco-nym dynco-nym requested a review from octol November 26, 2024 10:18
@dynco-nym dynco-nym added this to the Reeses milestone Nov 26, 2024
@dynco-nym dynco-nym merged commit e7f8062 into develop Nov 26, 2024
16 of 17 checks passed
@dynco-nym dynco-nym deleted the dz-ns-client branch November 26, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants