Bugfix/contract version assignment #5318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
commented
Jan 8, 2025
| @@ -34,9 +34,13 @@ impl NymNodeVersionHistory<'_> { | |||
| } | |||
|
|
|||
| fn next_id(&self, storage: &mut dyn Storage) -> Result<u32, MixnetContractError> { | |||
| let next = self.id_counter.may_load(storage)?.unwrap_or_default(); | |||
There was a problem hiding this comment.
this was the bug. it was always returning "0"
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
jstuczyn
force-pushed
the
bugfix/contract-version-assignment
branch
from
2a3d9fb to
e8aeb4d
Compare
tommyv1987
requested review from
octol and
durch
and removed request for
durch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes updates to current nym-node version as well as introduces migration to fix the existing state of the mainnet contract
This change is