IPR request types v8 #5498
IPR request types v8 #5498
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
octol
force-pushed
the
jon/reply-tests
branch
from
95a1b3f to
698ad14
Compare
octol
force-pushed
the
jon/reply-tests
branch
from
f10d29e to
70fb73b
Compare
service-providers/ip-packet-router/src/clients/connected_client_handler.rs
Outdated
Show resolved
Hide resolved
service-providers/ip-packet-router/src/clients/connected_client_handler.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Reviewed 31 of 31 files at r1, all commit messages.
Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @octol)
service-providers/ip-packet-router/src/clients/connected_client_handler.rs line 33 at r1 (raw file):
pub(crate) struct ConnectedClientHandler { // The address of the client that this handler is connected to // nym_address: Recipient,
This looks like it could be removed
service-providers/ip-packet-router/src/clients/connected_client_handler.rs line 81 at r1 (raw file):
let connected_client_handler = ConnectedClientHandler { // nym_address: reply_to, // reply_to_tag,
This too
sdk/rust/nym-sdk/src/mixnet/native_client.rs line 284 at r1 (raw file):
// I *think* this happens for SURBs, but I'm not 100% sure. Nonetheless it's // beneign, but let's log it here anyway as a reminder debug!("the reconstructed messages vector is empty - please let the developers know if you see this message");
Reading the message, this doesn't seem like a debug message. Maybe the content also needs to be updated?
There was a problem hiding this comment.
Reviewable status: 8 of 45 files reviewed, 8 unresolved discussions (waiting on @jstuczyn and @neacsu)
sdk/rust/nym-sdk/src/mixnet/native_client.rs line 284 at r1 (raw file):
Previously, neacsu (Bogdan-Ștefan Neacşu) wrote…
Reading the message, this doesn't seem like a debug message. Maybe the content also needs to be updated?
Updated the message
service-providers/ip-packet-router/src/clients/connected_client_handler.rs line 33 at r1 (raw file):
Previously, neacsu (Bogdan-Ștefan Neacşu) wrote…
This looks like it could be removed
Done.
service-providers/ip-packet-router/src/clients/connected_client_handler.rs line 81 at r1 (raw file):
Previously, neacsu (Bogdan-Ștefan Neacşu) wrote…
This too
Done.
Since the IPR can run as a binary, make sure it's license is GPL-3.0
octol
force-pushed
the
jon/reply-tests
branch
from
dcfb158 to
574a188
Compare
Bump IPR request/response types to v8
This change is