Feature/ts client update #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsinclair
requested changes
Dec 15, 2021
There was a problem hiding this comment.
Generally looking good, only a couple of minor things:
- can tidy up bits of the syntax (I'm being a little pedantic with those changes, but I feel they produce less code)
- I'll add a commit with
eslintorprettierafterwards because the files could do with some consistency on formatting and it has good suggestions for TS and general code structure (it ain't a clippy but it is ok)
mmsinclair
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our TypeScript client to restore functionalities of being able to query our contract, validator API as well as send transactions such as bonding mixnodes.
For the purposes of this review, I think it would make more sense to pull the branch and look at the files themselves rather than using the github's diff tab.
Addresses #2096