Reintroduce "Parallelise perm_aggreg" w/ bugfix #3121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anne-laure-s
approved these changes
Apr 2, 2025
| let mut z: Vec<F> = witness | ||
| .par_iter() | ||
| .zip(self.column_evaluations.permutation_coefficients8.par_iter()) | ||
| .map(|(w_i, perm_coeffs8_i)| { |
There was a problem hiding this comment.
I would keep the name s instead of perm_coeffs as it is the one in the comment, it’s shorter and it make sense if you know plonk
There was a problem hiding this comment.
I wanted to rename for clarity, I was confused by s (thought it was shifts), and it's consistent with the general effort to use more self-descriptive variable names...
Comment on lines
+511
to
+527
| let z_prefolded: Vec<F> = witness | ||
| .par_iter() | ||
| .zip(self.cs.shift.par_iter()) | ||
| .map(|(w_i, shift_i)| { | ||
| let mut output_vec: Vec<_> = vec![F::one(); 1]; | ||
| for (j, w_i_j) in w_i.iter().enumerate().take(n - 1) { | ||
| output_vec.push(*w_i_j + (self.cs.sid[j] * beta * shift_i) + gamma); | ||
| } | ||
| output_vec | ||
| }) | ||
| .reduce_with(|mut l, r| { | ||
| for i in 0..n { | ||
| l[i] *= &r[i]; | ||
| } | ||
| l | ||
| }) | ||
| .unwrap(); |
There was a problem hiding this comment.
The code could probably be unified with the code of z.
|
Merging this. The PR passes mina tests now and I'm fairly sure it works -- even though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit was reverted here #3105 due to the indices bug, which is fixed in this PR.
minaPR: MinaProtocol/mina#16812