Skip to content

cmd/rofl/deploy: Fix --provider behaviour #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

cmd/rofl/deploy: Fix --provider behaviour #455

merged 1 commit into from
May 10, 2025
+29 −12

Conversation

matevz
Copy link
Member

@matevz matevz commented May 9, 2025

This PR:

  • fixes regression introduced by ccc43db . You couldn't deploy a new version of ROFL on the existing machine, because --provider parameter wasn't empty anymore.
  • uses the Testnet provider only if Testnet Sapphire ParaTime is selected
  • fixes CLI complaining, if you wanted to deploy to an existing machine that matches the --provider name.

@matevz matevz requested a review from kostko May 9, 2025 22:43
@netlify Netlify
Copy link

netlify bot commented May 9, 2025 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 7bb4103
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/681f330e8e2bed0008fbb6ba

kostko
kostko reviewed May 10, 2025
View reviewed changes
@matevz matevz force-pushed the matevz/fix/existing-provider-machine branch from 35f592c to 13d1774 Compare May 10, 2025 09:33
@matevz matevz requested a review from kostko May 10, 2025 09:33
@matevz matevz force-pushed the matevz/fix/existing-provider-machine branch 2 times, most recently from c341f3e to 3c043ee Compare May 10, 2025 11:04
@matevz matevz force-pushed the matevz/fix/existing-provider-machine branch from 3c043ee to 7bb4103 Compare May 10, 2025 11:05
@matevz matevz merged commit 29951d6 into master May 10, 2025
4 checks passed
@matevz matevz deleted the matevz/fix/existing-provider-machine branch May 10, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matevz @kostko