Upgrade to be kcas 0.4.0 compatible #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adapts Reagents to the following changes in kcas: - kcas_data 0.2.4 includes a `Queue` module. - kcas 0.3.0 removed the `Tx` api. - kcas 0.4.0 added an optional `mode` argument to locations.
polytypic
force-pushed
the
upgrade-to-kcas-0.4.0
branch
from
697ec4e to
8b60757
Compare
polytypic
commented
May 17, 2023
| @@ -1,3 +1,3 @@ | |||
| (library | |||
| (name references) | |||
| (libraries kcas unix)) | |||
| (libraries unix)) | |||
There was a problem hiding this comment.
I just decided to drop the two kcas based reference queues as we can use the Kcas_data.Queue.
polytypic
commented
May 17, 2023
| @@ -19,7 +19,7 @@ module Op = Kcas.Op | |||
|
|
|||
| type 'a ref = 'a Loc.t | |||
|
|
|||
| let ref = Loc.make | |||
| let ref x = Loc.make x | |||
There was a problem hiding this comment.
This allows Loc.make to take optional arguments.
bartoszmodelski
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts Reagents to the following changes in kcas:
Queuemodule.Txapi.modeargument to locations.