Switch from OMP to ppxlib #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
Aug 11, 2020
|
You should have commit bit in this repo now, so you can merge it yourself (and cut a release if you need it). |
|
thanks 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when I made #6 I overlooked the current plan regarding
ocaml-migrate-parsetree. Turns out this won't be compatible with the upcomingocaml-migrate-parsetree.2.0.0(see https://discuss.ocaml.org/t/ocaml-migrate-parsetree-2-0-0/5991) to be released tomorrow: ocaml/opam-repository#16999In view of that and the very welcome change that came with
ppxlib 0.15.0which removed the dependencies towardsbaseandstdio(see ocaml/opam-repository#16965), I believe that switching to useppxlibis the correct choice.Sorry for doubling your work of maintainer.