Skip to content

Update Wasm_of_ocaml action #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Leonidas-from-XIV
Copy link
Collaborator

The attempts to update the workflow as Wasm_of_ocaml has been merged upstream in ocsigen/js_of_ocaml#1724 and the wasm-dune branch is gone.

The attempts to update the workflow as Wasm_of_ocaml has been merged
upstream in ocsigen/js_of_ocaml#1724 and the
wasm-dune branch is gone.

Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV Leonidas-from-XIV added the chore Something that just needs to be done. label Dec 5, 2024
@vouillon
Copy link
Member

vouillon commented Dec 5, 2024

Oh, sorry. I forgot this branch was still used.

@Leonidas-from-XIV
Copy link
Collaborator Author

No worries. However, I don't know what the state of wasm_of_ocaml or this workflow is, is the fix submitted the right solution or does it need something else? It does seem to pass CI successfully.

@vouillon
Copy link
Member

vouillon commented Dec 5, 2024

Yes, this is the right solution. The wasm_of_ocaml development has been moved to the js_of_ocaml repository.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 5eeb823 into ocaml:main Dec 6, 2024
28 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the attempt-update-wasm branch December 6, 2024 09:34
chris-armstrong pushed a commit to chris-armstrong/dune that referenced this pull request Jan 29, 2025
The attempts to update the workflow as Wasm_of_ocaml has been merged
upstream in ocsigen/js_of_ocaml#1724 and the
wasm-dune branch is gone.

Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Chris Armstrong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that just needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants