feat: add new -testEnv option for fastchess #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this option fastchess prints all necessary debug information for illegal pv moves in one line. Which means fishtest is able to properly propagate this back to the user viewing the Events log. See Disservin/fastchess#812.
ppigazzini
added
enhancement
worker update
ppigazzini
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Looks good on DEV with linux/windows workers. PROD update in seconds, thank you @Disservin :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this option fastchess prints all necessary debug information for illegal pv moves in one line, seperated by
::instead of\n. Which means fishtest is able to properly propagate this back to the user viewing the Events log. Hopefully adding more debug information to help users fix their tests and maybe official-stockfish/Stockfish#5890.See Disservin/fastchess#812.
Also removed some dead code.