Behavior change in lstrip_blocks in Jinja 2.11.0 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinja 2.11.0 got released a couple days ago, and it changed the behavior of lstrip_blocks. This breaks some templates. It's not yet clear if we misunderstood the lstrip_blocks documentation (and things were never expected to work that way), or if Jinja2 introduced a breaking change. Upstream bug report pallets/jinja#1138
imphil
force-pushed
the
jinja-lstrip-blocks-workaround
branch
from
9c08970 to
13faadf
Compare
imphil
changed the title
|
I must say I'm still not super happy with jinja in general, but anyway, let's fix this first at least. |
|
Olof, is there some workaround possible for the jinja2 issue? Fedora 32 will be released with jinja 2.11.1 and thus making edalize/fusesoc uninstalable. |
|
This is scheduled to be fixed in an upcoming Jinja2 release, which hasn't happened yet unfortunately. In the meantime, I see a couple of options:
|
|
Or just get rid of that stupid jinja thing. I'm getting increasingly tired of it and it doesn't really add much value |
|
Jinja2 has now released 2.11.2 which fixed this regression, I'd expect Fedora can update to this point release in an update. |
|
already built for Rawhide and F-32 (https://bodhi.fedoraproject.org/updates/FEDORA-2020-3937030d54), F<=31 stay on 2.10 |
bwitherspoon
pushed a commit
to bwitherspoon/edalize
that referenced
this pull request
Dec 17, 2023
The new command `fusesoc dep graph` creates a GraphViz .dot file
listing all dependencies for a given core with given flags. This file
can be either manually converted into an image using the `dot` tool
(part of the GraphViz package), or automatically converted with FuseSoC
through the `--output-format` command line option.
Full documentation:
```
$ fusesoc dep graph --help
usage: fusesoc dep graph [-h] [--target TARGET] [--tool TOOL] [--output-format OUTPUT_FORMAT] core
positional arguments:
core Core to build the dependency graph for.
optional arguments:
-h, --help show this help message and exit
--target TARGET Target to build the dependency graph for.
--tool TOOL Tool to build the dependency graph for.
--output-format OUTPUT_FORMAT
Convert output into desired format (requires dot). All dot-supported formats can be used, run 'dot -T?' for a complete list.
```
Based on inital work by Stefan Wallentowitz in olofk#99
Fixes olofk#98
bwitherspoon
pushed a commit
to bwitherspoon/edalize
that referenced
this pull request
Dec 17, 2023
The new command `fusesoc dep graph` creates a GraphViz .dot file
listing all dependencies for a given core with given flags. This file
can be either manually converted into an image using the `dot` tool
(part of the GraphViz package), or automatically converted with FuseSoC
through the `--output-format` command line option.
Full documentation:
```
$ fusesoc dep graph --help
usage: fusesoc dep graph [-h] [--target TARGET] [--tool TOOL] [--output-format OUTPUT_FORMAT] core
positional arguments:
core Core to build the dependency graph for.
optional arguments:
-h, --help show this help message and exit
--target TARGET Target to build the dependency graph for.
--tool TOOL Tool to build the dependency graph for.
--output-format OUTPUT_FORMAT
Convert output into desired format (requires dot). All dot-supported formats can be used, run 'dot -T?' for a complete list.
```
Based on inital work by Stefan Wallentowitz in olofk#99
Fixes olofk#98
bwitherspoon
pushed a commit
to bwitherspoon/edalize
that referenced
this pull request
Dec 17, 2023
The new command `fusesoc dep graph` creates a GraphViz .dot file
listing all dependencies for a given core with given flags. This file
can be either manually converted into an image using the `dot` tool
(part of the GraphViz package), or automatically converted with FuseSoC
through the `--output-format` command line option.
Full documentation:
```
$ fusesoc dep graph --help
usage: fusesoc dep graph [-h] [--target TARGET] [--tool TOOL] [--output-format OUTPUT_FORMAT] core
positional arguments:
core Core to build the dependency graph for.
optional arguments:
-h, --help show this help message and exit
--target TARGET Target to build the dependency graph for.
--tool TOOL Tool to build the dependency graph for.
--output-format OUTPUT_FORMAT
Convert output into desired format (requires dot). All dot-supported formats can be used, run 'dot -T?' for a complete list.
```
Based on inital work by Stefan Wallentowitz in olofk#99
Fixes olofk#98
bwitherspoon
pushed a commit
to bwitherspoon/edalize
that referenced
this pull request
Dec 17, 2023
The new command `fusesoc dep graph` creates a GraphViz .dot file
listing all dependencies for a given core with given flags. This file
can be either manually converted into an image using the `dot` tool
(part of the GraphViz package), or automatically converted with FuseSoC
through the `--output-format` command line option.
Full documentation:
```
$ fusesoc dep graph --help
usage: fusesoc dep graph [-h] [--target TARGET] [--tool TOOL] [--output-format OUTPUT_FORMAT] core
positional arguments:
core Core to build the dependency graph for.
optional arguments:
-h, --help show this help message and exit
--target TARGET Target to build the dependency graph for.
--tool TOOL Tool to build the dependency graph for.
--output-format OUTPUT_FORMAT
Convert output into desired format (requires dot). All dot-supported formats can be used, run 'dot -T?' for a complete list.
```
Based on inital work by Stefan Wallentowitz in olofk#99
Fixes olofk#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja 2.11.0 got released a couple days ago, and it changed the behavior
of lstrip_blocks. This breaks some templates.
It's not yet clear if we misunderstood the lstrip_blocks documentation
(and things were never expected to work that way), or if Jinja2
introduced a breaking change.
Upstream bug report pallets/jinja#1138