Add more logging for confluence perm-sync + handle case where permiss… #4586
+1,007
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances logging and error handling in Confluence permission synchronization, focusing on better visibility and secure defaults when permissions cannot be determined.
- Added detailed logging in
doc_sync.pyfor space permissions and document restrictions with elevated log levels for better visibility - Implemented secure fallback in
doc_sync.pyto make documents inaccessible when permissions cannot be determined - Added handling in
doc_sync.pyfor documents that exist in DB but are no longer accessible in Confluence - Enhanced error messages in
doc_sync.pywith specific details about permission-related issues - Elevated log levels in
group_sync.pyfrom debug to info for user processing and group assignment visibility
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -17,7 +17,7 @@ def _build_group_member_email_map( | |||
| ) -> dict[str, set[str]]: | |||
| group_member_emails: dict[str, set[str]] = {} | |||
| for user in confluence_client.paginated_cql_user_retrieval(): | |||
| logger.debug(f"Processing groups for user: {user}") | |||
| logger.info(f"Processing groups for user: {user}") | |||
There was a problem hiding this comment.
style: Consider keeping this as debug level since it could be very noisy in production with many users
Weves
force-pushed
the
confluence-perm-sync
branch
2 times, most recently
from
dfb9d3d to
8925869
Compare
…ions are removed from the access token
Weves
force-pushed
the
confluence-perm-sync
branch
from
97a7a50 to
ae7ac7a
Compare
Weves
commented
Apr 30, 2025
| .get("user", {}) | ||
| .get("displayName", "Unknown User") | ||
| ) | ||
| # NOTE: needs to be done this weird way because sometime we get back `None` for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions are removed from the access token.
Also has:
Fixes https://linear.app/danswer/issue/DAN-1932/permission-sync-500
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.