adds "Branch here" functionality as footer-button #6967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge dev branch
…babooga#6749) --------- Co-authored-by: oobabooga <[email protected]>
Merge dev branch
Merge dev branch
- **UI & HTML:**
- Grouped message action buttons (copy, regenerate, etc.) into a new `.message-actions` div for better organization and styling.
- Added a "Branch here" button with a new SVG icon to each assistant/bot message.
- Assistant/bot messages now include a `data-index` attribute.
- **JavaScript:**
- Implemented `branchHere(element)` function that, when a "Branch here" button is clicked:
- Retrieves the `data-index` of the message.
- Populates a hidden `branch_index` Gradio input field with this index.
- Programmatically clicks the main "Branch" button.
- **Backend (Python):**
- The `handle_branch_chat_click` function in `modules/chat.py` now:
- Accepts a `branch_index` from the state.
- If `branch_index` is provided (not -1), it truncates the current chat history up to (and including) that index before creating the new branched chat.
- Resets `branch_index` to -1 after branching.
- Added `branch_index` to the Gradio interface state and input elements.
|
This change is excellent -- I haven't had time to review it properly yet but I'll merge it as soon as I confirm it works without issues. I see that you have made some nice code quality improvements as well. On a side note, I think that a similar logic (plus some CSS styling) could be used to edit past messages and replies, similar to how the ChatGPT UI works. If you are interested in adding this in a future PR, that would be helpful. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply allows, in addition, branching at a specific assistant response by adding a new icon under each response.
.message-actionsdiv for better organization and styling.data-indexattribute.branchHere(element)function that, when a "Branch here" button is clicked:data-indexof the message.branch_indexGradio input field with this index.handle_branch_chat_clickfunction inmodules/chat.pynow:branch_indexfrom the state.branch_indexis provided (not -1), it truncates the current chat history up to (and including) that index before creating the new branched chat.branch_indexto -1 after branching.branch_indexto the Gradio interface state and input elements.Checklist: