helm chart for kueue addon #37
Conversation
|
/assign @zhujian7 |
| agentSpec: | ||
| workload: | ||
| manifests: | ||
| - apiVersion: rbac.authorization.k8s.io/v1 |
There was a problem hiding this comment.
for the spoke cluster do we need to install the kueue-addon-controller deployment?
There was a problem hiding this comment.
no, on the spoke, we just want to use template to deploy some kueue resources.
There was a problem hiding this comment.
But without the kueue controller, how would the multikueue resource be handled on the spoke when the hub distributes a workload to the spoke?
There was a problem hiding this comment.
This addon requires the user already installed kueue on both hub and spoke. The kueue workload is managed by kueue.
There was a problem hiding this comment.
ok, so can we add some doc/readme to describe the prereq and how to use this?
There was a problem hiding this comment.
Yes! That's a good suggestion. Will update the doc when the image is pushed to quay.io. Today the readme is still TBD https://github.com/open-cluster-management-io/addon-contrib/blob/main/kueue-addon/README.md means it's not ready to use yet.
There was a problem hiding this comment.
readme for this addon #39
|
/assign @qiujian16 |
| description: A Helm chart for Open Cluster Management Kueue Addon | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "1.0.0" |
There was a problem hiding this comment.
This is just referring to other addons like managed-serviceaccount set to 1.0.0 as the initial version.
Any suggestion for this? like be aligned with the supported kueue version, as well as the kueue addon controller image version?
There was a problem hiding this comment.
yes align with kueue version would be better.
| installStrategy: | ||
| type: Placements | ||
| placements: | ||
| - name: {{ .Values.placement.hub.name }} |
There was a problem hiding this comment.
why do we need a special treatment on hub?
| apiVersion: addon.open-cluster-management.io/v1alpha1 | ||
| kind: AddOnTemplate | ||
| metadata: | ||
| name: kueue-addon-hub-{{ .Chart.Version }} |
There was a problem hiding this comment.
this is strange, do we need to install this on hub?
There was a problem hiding this comment.
The intention here is to manage the lifecycle of kueue addon controller by cma. Will you suggest to install it (deployment, rbac) directly through yamls?
There was a problem hiding this comment.
Removed the kueue-addon-hub template and install them directly by yamls.
haoqing0110
force-pushed
the
br_kueue-helm-chart
branch
from
cebb288 to
0c40ab9
Compare
Signed-off-by: Qing Hao <[email protected]>
haoqing0110
force-pushed
the
br_kueue-helm-chart
branch
from
0c40ab9 to
a6a1ce0
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7ab7dff
into
open-cluster-management-io:main
ref open-cluster-management-io/ocm#907