Skip to content

Add YOLOX variants to OTX #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 27, 2023

Conversation

jaegukhyun
Copy link
Contributor

@jaegukhyun jaegukhyun commented Jul 26, 2023

Summary

This PR includes adding YOLOX variants to OTX.
Current existed YOLOX is YOLOX-TINY, the smallest YOLOX variant.
As YOLOX variants show good performance w.r.t accuracy and time, it would be nice to add these YOLOX variants to OTX

Here's some experiments summary.

  YOLOX-TINY YOLOX_S YOLOX_L YOLOX_X Mobilenet-ATSS ResNeXt-ATSS Deformable-DETR DINO(batch_size = 2)
BCCD 0.89204 0.92738 0.91809 0.91937 0.93432 0.93183 0.93519 0.93547
BCCD-SMALL 0.88939 0.95498 0.94772 0.95075 0.91623 0.92484 0.93639 0.8975
FISH 0.93533 0.89212 0.90926 0.91508 0.95663 0.96321 0.82701 0.95005
FISH-SMALL 0.92424 0.77778 0.91667 0.92857 0.83333 0.95833 0.89583 0.95833
POTHOLE 0.73111 0.71877 0.7034 0.75255 0.7971 0.82397 0.77126 0.81455
POTHOLE-SMALL 0.27465 0.32187 0.35799 0.41236 0.43391 0.53674 0.25408 0.39816
VITENS 0.86252 0.86503 0.87652 0.87972 0.87637 0.88967 0.88476 0.91272
VITENS-SMALL 0.76822 0.85981 0.87009 0.87258 0.8391 0.87448 0.7958 0.896
BDD100K 0.248 0.371 0.445 0.442 0.402 0.455(Fixed schedule) 0.448(Fixed schedule) 0.472(Fixed schedule)

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Jul 26, 2023
@jaegukhyun jaegukhyun marked this pull request as ready for review July 26, 2023 07:42
@jaegukhyun jaegukhyun requested a review from a team as a code owner July 26, 2023 07:42
Copy link

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the task type prefix like Object_Detection_YOLOX_S but open to discussion. Anyway, we would follow some convention afterwards.
@sungmanc @eunwoosh What do you think?

@jaegukhyun
Copy link
Contributor Author

I prefer the task type prefix like Object_Detection_YOLOX_S but open to discussion. Anyway, we would follow some convention afterwards. @sungmanc @eunwoosh What do you think?

I agree on having prefix for unity. Object_Detection seems fine.

@sungmanc
Copy link
Contributor

I prefer the task type prefix like Object_Detection_YOLOX_S but open to discussion. Anyway, we would follow some convention afterwards. @sungmanc @eunwoosh What do you think?

I also prefer to use the task type prefix. Sometimes, it could be helpful to identify easily.

sungmanc
sungmanc previously approved these changes Jul 26, 2023
@goodsong81 goodsong81 added this to the 1.5.0 milestone Jul 26, 2023
goodsong81
goodsong81 previously approved these changes Jul 26, 2023
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think HPO configuration need to be changed. Please take a look.

@eunwoosh
Copy link
Contributor

I prefer the task type prefix like Object_Detection_YOLOX_S but open to discussion. Anyway, we would follow some convention afterwards. @sungmanc @eunwoosh What do you think?

Yes I agree to use the prefix they said.

eunwoosh
eunwoosh previously approved these changes Jul 27, 2023
@jaegukhyun jaegukhyun requested a review from eunwoosh July 27, 2023 03:35
@jaegukhyun jaegukhyun enabled auto-merge (squash) July 27, 2023 03:36
@jaegukhyun jaegukhyun merged commit 84b0b8b into open-edge-platform:develop Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants