-
Notifications
You must be signed in to change notification settings - Fork 449
Add YOLOX variants to OTX #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jaegukhyun
merged 15 commits into
open-edge-platform:develop
from
jaegukhyun:yolox_variants
Jul 27, 2023
Merged
Add YOLOX variants to OTX #2402
jaegukhyun
merged 15 commits into
open-edge-platform:develop
from
jaegukhyun:yolox_variants
Jul 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodsong81
reviewed
Jul 26, 2023
docs/source/guide/explanation/algorithms/object_detection/object_detection.rst
Outdated
Show resolved
Hide resolved
goodsong81
reviewed
Jul 26, 2023
src/otx/algorithms/detection/configs/detection/cspdarknet_yolox_s/deployment.py
Outdated
Show resolved
Hide resolved
goodsong81
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sungmanc
previously approved these changes
Jul 26, 2023
goodsong81
previously approved these changes
Jul 26, 2023
eunwoosh
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I think HPO configuration need to be changed. Please take a look.
src/otx/algorithms/detection/configs/detection/cspdarknet_yolox_l/hpo_config.yaml
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/configs/detection/cspdarknet_yolox_s/hpo_config.yaml
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/configs/detection/cspdarknet_yolox_x/hpo_config.yaml
Outdated
Show resolved
Hide resolved
eunwoosh
previously approved these changes
Jul 27, 2023
sungmanc
approved these changes
Jul 27, 2023
goodsong81
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes adding YOLOX variants to OTX.
Current existed YOLOX is YOLOX-TINY, the smallest YOLOX variant.
As YOLOX variants show good performance w.r.t accuracy and time, it would be nice to add these YOLOX variants to OTX
Here's some experiments summary.
Checklist
License
Feel free to contact the maintainers if that's a concern.