Skip to content

Update NNCF Dataloader in Anomaly Task #3926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashwinvaidya17
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Ashwin Vaidya <[email protected]>
@harimkang
Copy link
Contributor

I have a question, don't some of the models in the anomaly task have no validation, and in certain cases do use them without validation data?

@ashwinvaidya17
Copy link
Contributor Author

I have a question, don't some of the models in the anomaly task have no validation, and in certain cases do use them without validation data?

We use validation set in Anomalib for finding the normalization thresholds. It is also used by few-shot models for reference images. If validation set is not used in anomaly tasks in OTX then that is a bug in the workflow.

@sovrasov sovrasov added this pull request to the merge queue Sep 5, 2024
Merged via the queue into open-edge-platform:develop with commit 709d841 Sep 5, 2024
18 checks passed
eugene123tw pushed a commit to eugene123tw/training_extensions that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants